Unset prefixes #136
Merged
Unset prefixes #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // These two must be in-step. | ||
| /** Function applied to undefined prefixes to convert to a URI string */ | ||
| public static final Function<String,String> fixupPrefixes = (x) -> "::"+x ; |
There was a problem hiding this comment.
This could be
private static final String URI_SKELETON = "::";
...
public static final Function<String,String> fixupPrefixes = URI_SKELETON::concat;
I find that clearer, because it names the string, but then, my tastes are odd.
There was a problem hiding this comment.
I'm probably missing something here, but it seems like this is only ever used unwrapped, via fixupPrefixes.apply, and that's down below in this class (where it is used instead of using fixupPrefixIRI(String), but I'm not sure why). Maybe it would be clearer to have an ordinary method and in future, if a function is needed, to use a method reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENA-1165 : Support for handlign undefined prefixes, especially in command line tools.
The default setting everywhere is "off".